Abstract: An improved floating weir and strainer basket combination for use in a swimming pool skimmer, having a tank adapted to receive the strainer basket and the floating weir in telescoping relation with each other. Accordingly, when the skimmer is suitably positioned in a body of water, the floating weir rests on a pocket of air which enables it to move vertically within the strainer basket in response to changes in water level. To prevent misalignment or disassociation of the floating weir with respect to the strainer basket, a disengageable mechanism is provided for retaining the weir in the basket. In the disclosed embodiment, the disengageable retaining mechanism comprises at least three equally spaced projections disposed on the outer wall surface of the floating weir, and at least three corresponding notches disposed on the inside periphery of a flange on the strainer basket.