Abstract: A commutator comprises a commutator base, a plurality of commutator segments, and means securing the segments on the base. Each segment has an integral terminal provided with a slot which is open at one end for receiving a connector portion of an armature winding and which is arranged so as in use to straddle and grip the connector portion to electrically connect the commutator segment to the armature winding. The commutator is pre-assembled in that the segments and the commutator base are formed as a unit prior to mounting the commutator on the armature of a motor and can be connected to an armature winding by a mechanical connection without the application of heat.